Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Published 20 hours ago • verified publisher icon LAION-AI

Initial plugins code cleanup

Open olliestanley opened this issue 1 year ago • 5 comments

The primary contributions of this PR are:

  • Introduce PromptedLLM class to manage the repeated process of preparing prompt with memory and template, calling LLM, and postprocessing output
  • Separating out functions in openapi_parser
  • General improvements to clarity/readability

olliestanley avatar May 10 '23 16:05 olliestanley

Nice job! LGTM, But I would love to manually test this branch a bit more before merging if possible?

draganjovanovich avatar May 13 '23 09:05 draganjovanovich

Nice job! LGTM, But I would love to manually test this branch a bit more before merging if possible?

Sure, no problem. Let me know when you're happy for it to be merged

olliestanley avatar May 13 '23 09:05 olliestanley

@draganjovanovich the last commit I have pushed to this branch should address #3146. Please let me know if you think there is any problem with this solution.

olliestanley avatar May 13 '23 10:05 olliestanley

@draganjovanovich the last commit I have pushed to this branch should address #3146. Please let me know if you think there is any problem with this solution.

yes, yes. I had that in my local repo, but left it uncommitted. Thanks.

draganjovanovich avatar May 13 '23 10:05 draganjovanovich

I tested it on a local setup, and everything seems fine.

draganjovanovich avatar May 15 '23 15:05 draganjovanovich

I have some more improvements for plugins that would like to open PR, but It would be best if that could be merged before that?

draganjovanovich avatar May 19 '23 12:05 draganjovanovich