Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Improve inference export script

Open olliestanley opened this issue 1 year ago • 4 comments

inference/server/export.py

  • Add ability to filter by conditions
  • Include a filter for only chats which have at least one assistant message with score != 0
  • Include a filter for specific date ranges
  • Consider performance improvements such as use of lazy loading from the database

olliestanley avatar May 05 '23 09:05 olliestanley

I'd like to work on this

simonusher avatar May 05 '23 23:05 simonusher

I'd like to work on this

Thank you, have assigned it to you.

olliestanley avatar May 06 '23 07:05 olliestanley

I've added the simple filters - date range, user id and chat id. Will need a bit more time to figure out how to set up the dev env to actually test it.

I also have a few things to clarify:

  • should user_id and chat_id filters be for single user/chat or should they allow for multiple values?
  • there's a todo comment in code that lists a couple of filters, including "... reported, score. You mentioned the score filter above - at least one assistant message with score != 0. What about reported? Should it only include chats with at least one reported message?

simonusher avatar May 07 '23 10:05 simonusher

  • should user_id and chat_id filters be for single user/chat or should they allow for multiple values?

Single value is fine for this

  • there's a todo comment in code that lists a couple of filters, including "... reported, score. You mentioned the score filter above - at least one assistant message with score != 0. What about reported? Should it only include chats with at least one reported message?

Yes, a filter for chats with at least one reported message would be a great addition :)

olliestanley avatar May 07 '23 15:05 olliestanley