Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Added guidelines to sidebar

Open owenduncansnobel opened this issue 2 years ago • 4 comments

I added the guidelines tab to the sidebar. I also updated the '?' links to point to corresponding guidelines page / sections

Screenshot 2023-02-20 at 3 20 23 AM

Corresponding '?' had the links also updated Screenshot 2023-02-20 at 3 20 43 AM

Screenshot 2023-02-20 at 3 20 58 AM

owenduncansnobel avatar Feb 20 '23 08:02 owenduncansnobel

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Feb 20 '23 08:02 github-actions[bot]

@owen-duncan-snobel thanks a lot for changes! Could you resolve the merge conflicts?

andreaskoepf avatar Feb 20 '23 10:02 andreaskoepf

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Feb 20 '23 15:02 github-actions[bot]

@andreaskoepf I fixed the merge conflicts

owenduncansnobel avatar Feb 20 '23 15:02 owenduncansnobel

@owen-duncan-snobel I see you replaced the help links of each task with the respective section in the guidelines - but doesn't that make the task docs obsolete? I specifically rewrote them to tell the user to read the guidelines, as well as a link for each task.

Of course, when clicking the "Guidelines" button, you'd expect the guidelines to show up, but the help links originally were supposed to lead to a document telling the user what to do. @andreaskoepf asked me to rewrite them, as I did in #1709.

Maybe we can have two different links, one for the task doc, and one that directly leads to the guidelines?

horribleCodes avatar Feb 22 '23 12:02 horribleCodes

@horribleCodes That's my fault .. I explicitly requested to replace the links in the issue https://github.com/LAION-AI/Open-Assistant/issues/1663 because the last time I checked the task pages were effectively empty. Could you please create a PR that changes the links back to the individual task-pages in the documentation?

andreaskoepf avatar Feb 22 '23 13:02 andreaskoepf

Sure, I can do that.

horribleCodes avatar Feb 22 '23 13:02 horribleCodes