Open-Assistant
Open-Assistant copied to clipboard
LAION-AI
Links in header and footer don't always resolve to a valid page
This issue is a continuation of #132
In our index.tsx we show two different pages if the user is signed in vs not.
However, many links in the headers and footer point to the un-logged-in variant of the page, example.
We need re-structure of our site paths, also considering other needed pages such as #46.
Suggestion:
I think it would make sense to leave / as non-logged user, and maybe add a /app that shows the available tasks & such. This will require new buttons or nav items to navigate to the app if you are logged in.
having a /about is never a bad idea.
Questions:
- do we need to worry about slugs / SEO? or just wing it?
Yeah I like this idea. /app is the signed in page and is blocked by the middleware. Then some initial stubs for the other links. With the new footer links I'm not sure we need a join us or faq in the top bar. Those fit better at the bottom.
When I get to the privacy policy my plan was to add
/privacy-policy/terms-of-service
Then we should additionally have:
/about/
as the public pages.
We should discuss if the leaderboard should be public. That'd probably go under /leaderboard.
Next up, i'll make a new page (either /home or /app) that's scoped to signed in users. I don't think we actually need other nav links. The header link can always go to /home when a user is signed in and / when they're not.
I think PR #312 will close out the final change needed. /dashboard is sufficient for signed in users.
I updated the PR to close this as it creates /dashboard. The one outstanding thing to fix is to make sure the link in the header for a signed in user goes to /dashboard. I forgot about that when marking this to close.