Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

website: Fix hydration issues side menu, move side_menu.json to common.json

Open rjmacarthy opened this issue 2 years ago • 1 comments

Fixes #1326

This PR moves all json in side_menu.json to common.json. We have an issue with the side menu layout as it's a high level component and this causes hydration issues with SSR when global namespaces are not passed by default.

Any questions please reach out.

rjmacarthy avatar Feb 07 '23 20:02 rjmacarthy

Conflicts resolved, it would be good to merge this before any more translation PRs are merged @fozziethebeat.

rjmacarthy avatar Feb 08 '23 08:02 rjmacarthy

Done [ru]

echo0x22 avatar Feb 08 '23 18:02 echo0x22

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Feb 08 '23 21:02 github-actions[bot]