Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Implemented ability to press ctrl+enter (or cmd+enter) to Review/Subm…

Open cooperaustinj opened this issue 2 years ago • 6 comments

Implemented ability to press ctrl+enter (or cmd+enter) to Review/Submit Create prompts

The first press of the shortcut is the same as pressing the Review button. The second press of the shortcut is the same as pressing Submit.

image

Fixes #811

cooperaustinj avatar Feb 06 '23 08:02 cooperaustinj

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Feb 06 '23 08:02 github-actions[bot]

Would it be possible to resolve the merge conflicts? Then i think we can wrap this PR up and merge it

fozziethebeat avatar Feb 11 '23 03:02 fozziethebeat

The localizations are still missing for most languages. I'd imagine we need those first?

cooperaustinj avatar Feb 11 '23 03:02 cooperaustinj

We can deal with localizations separately. For most changes we add the localizations for the languages the PR author speaks and then over time we'll get the other languages added in.

fozziethebeat avatar Feb 11 '23 03:02 fozziethebeat

@fozziethebeat Merge conflicts resolved!

cooperaustinj avatar Feb 12 '23 04:02 cooperaustinj

@cooperaustinj could you please resolve conflicts one more time?

andreaskoepf avatar Feb 20 '23 21:02 andreaskoepf

@AbdBarho I just pushed the change to allow submission via keyboard. The old implementation only allows previewing the answer only. This require to listen keydown event globally.

notmd avatar Mar 21 '23 08:03 notmd

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Mar 21 '23 08:03 github-actions[bot]