Open-Assistant
Open-Assistant copied to clipboard
LAION-AI
Initial Storybook setup
These changes enable to use npm run storybook to start storybook as mentioned in #102.
There is an example story for the header.
Maybe should be moved to the components folder when doing #99.
What is not finished:
- DataMocking
- fokus only on
components/rather thanpages/
What is finished:
- TailwindCSS and ChakraUI integration
Great first step! I have a few small requested changes then I'll merge this in.
Deleted the empty lines :)
I also moved the files so its more inline with future structure.
would make sense the have the stories in another folder? i.e. not between all the components? maybe in src/stories/...
I am suggesting this because stories are more of "write and forget", otherwise the files would be in the way all the time.
@jojopirker @fozziethebeat what do you think?
would make sense the have the stories in another folder? i.e. not between all the components? maybe in
src/stories/...I am suggesting this because stories are more of "write and forget", otherwise the files would be in the way all the time.
@jojopirker @fozziethebeat what do you think?
This is definitely a matter of preference and probably past experiences.
I like how RedwoodJS put the test and stories in the same directory as the component so that when you make changes to the component you're reminded to check the story or test and don't have to go find the corresponding file in some other parallel directory structure. Let's try this for now and then re-evaluate.
merged the previous changes... i also moved all the files of the header into /components/header so they are all in one place, and added and index file in the folder for better import
merged the previous changes... i also moved all the files of the header into
/components/headerso they are all in one place, and added and index file in the folder for better import
Thanks! I see a docker-compose 2.yaml file, this was not intended right?