Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Being able to review your own replies

Open HugoVG opened this issue 2 years ago • 3 comments

In the current implementation you are able to review your own answers/replies, i don't think this is a great thing because people can use it to give garbage replies and review them as really good image

HugoVG avatar Jan 30 '23 14:01 HugoVG

Was the highlighted message written by you or only earlier messages in the conversation? The system should not allow you to label your own messages but if your messages are parents of other user's replies they can show up.

andreaskoepf avatar Jan 30 '23 15:01 andreaskoepf

the highlighted message was from me.

HugoVG avatar Jan 30 '23 15:01 HugoVG

the highlighted message was from me.

OK, right now I don't know how this is possible since we filter based on the user id and the self-labeling option is off for the production instance.

https://github.com/LAION-AI/Open-Assistant/blob/091e93392bef64f51234fcdf2902463a0585bdac/backend/oasst_backend/tree_manager.py#L842-L843

I will add a test at a different location that will raise an exception if this happens. This might help us to identify under which circumstances this occurs.

andreaskoepf avatar Jan 30 '23 16:01 andreaskoepf