Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Published 20 hours ago • verified publisher icon LAION-AI

closes #731: add poetry-instructions dataset

Open IsaacRe opened this issue 2 years ago • 5 comments

Opening this up to get feedback on my code organization. See https://github.com/LAION-AI/Open-Assistant/issues/731 for details.

IsaacRe avatar Jan 30 '23 08:01 IsaacRe

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Jan 30 '23 08:01 github-actions[bot]

@IsaacRe Is this still WIP?

olliestanley avatar Feb 21 '23 16:02 olliestanley

@olliestanley the PR is ready to go

IsaacRe avatar Feb 22 '23 05:02 IsaacRe

@IsaacRe Sorry, could you please rebase this onto latest main? We have renamed openassistant directory to data. We have also added new code owners for the directory who will be able to review this once it is rebased :)

olliestanley avatar Feb 24 '23 17:02 olliestanley

Hey @IsaacRe! I know this PR is a little old but I recently also made a poetry dataset (before we found this PR). It wouldn't hurt to have two, but maybe we could work to combine them. Lmk what you think and if you're still interested in this

CheckMC avatar Apr 22 '23 15:04 CheckMC