ekg icon indicating copy to clipboard operation
ekg copied to clipboard

Add Cabal flag to embed assets with TH

Open fizruk opened this issue 7 years ago • 8 comments

@tibbe I see in https://github.com/tibbe/ekg/issues/22#issuecomment-48441966 that you don't want TH in this package:

Using TH brings a host of other issues (cross compilation not working, etc) and since people who ship software to other machines to run there eventually will need to figure out how to ship whole packages of files (i.e. executable plus various templates, data files, etc) anyway, I don't think it's worth it.

However, we're pretty fine with TH in dependencies and we've been using servant-swagger-ui that embeds its assets just fine.

So would you mind if we add a Cabal flag (disabled by default) that would enable TH-based embedding?

fizruk avatar Oct 04 '17 11:10 fizruk

I will leave it up to @23Skidoo to decide as he's the primary maintainer nowadays.

tibbe avatar Oct 04 '17 15:10 tibbe

I think that TH is fine if it's hidden behind a flag, but if you do this please also add a CI configuration that tests the TH build variant.

23Skidoo avatar Oct 04 '17 15:10 23Skidoo

@23Skidoo Nice, we'll of course add a CI configuration to build TH version too! We'll try to prepare a PR next week.

fizruk avatar Oct 05 '17 06:10 fizruk

@fizruk do you still plan to work on the PR ?

Unisay avatar Mar 06 '18 14:03 Unisay

@fizruk Have you guys arrived at anything in the end with this?

nikita-volkov avatar Oct 28 '19 11:10 nikita-volkov

@nikita-volkov @Unisay we have been using our fork which is linked in this discussion and can be found at https://github.com/GetShopTV/ekg/pull/1. We've been using it with Stack as follows:

- git: https://github.com/GetShopTV/ekg.git
  commit: f94af6a0fdd12e73a824c965c57053d7ce3e7ca1

We did not make the CI configuration for it at the time so we failed to report back here, sorry about that! Currently we are not using ekg much, so it has become a very low priority issue for us.

fizruk avatar Oct 29 '19 05:10 fizruk

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:


Bump. Would be great to get more discussion on this

brandon-leapyear avatar Nov 19 '20 17:11 brandon-leapyear

See https://github.com/tibbe/ekg/pull/77#issuecomment-730654534

tibbe avatar Nov 19 '20 21:11 tibbe