Benjamin
Benjamin
I can if wanted but I don't think it would be the cleanest solution. Since this was triggered by @meooow25's request, I ask that they approve as well before merging.
@meooow25 got around to undoing those changes. I keep my removal of IsInt in favour of `Int ~`. If it somehow fails the CI, then I'll revert that as well.
Happy to discuss IsInt on the other PR; one option is that we could use mhs in the testing pipeline as well if we do want to commit to non-ghc...
Do you have any recommendations for running benchmarks? I ran all of the benchmarks three times and got wildly different results each time. Ideally I'd run all of them one...
I ran `cabal bench all` before the changes, after, and then checked out master again and reran, and got very different results. I can certainly try running individual benchmarks; in...
Here are the results of benchmarking all the benchmarks in order one after the other: https://gist.github.com/L0neGamer/d0722ef0aea167684d87b63f786bb33f Here are the percentage differences of the end results of each: ``` intmap-benchmarks: +17.8%...
I'll look into running each of those later. Would the maintainers be interested if I took this opportunity to add the `x-partial` warning to all of these functions as well?
I don't think people should have to program with the documentation open necessarily. I think the thing with these warnings is that they're guards for beginner work or corporate codebases....
Been a bit busy, here are the results from running a baseline on master, then running against that baseline on this PR: https://gist.github.com/L0neGamer/d0722ef0aea167684d87b63f786bb33f#file-vs-baseline-out I count 1008 "same as baseline", 97...
As much as I would love to add `x-partial` warnings onto these functions, I don't think adding HasCallStack should be blocked on that. What do I need to do to...