Martin Kiesel
Martin Kiesel
@hwinkel +1
Hey @AAllport if it makes sense to you sure go ahead; please make sure you add proper tests and readme.
This looks like an edge case I did not think about :(. Can you post SQLs for both cases? You can get the SQLs from https://github.com/barryvdh/laravel-debugbar.
Have you tried implementing the sorting logic yourself using the https://github.com/Kyslik/column-sortable#columnsortable-overriding-advanced?
Hey @fomvasss, Do I understand the *why* of this PR. The sorting does not happen using links `` but rather via select-box? I've seen this kind of approach. Just making...
@nomura-axis Because I did not have time to vet it.
@fomvasss, @nomura-axis do you think you could add tests for this; I will happily vet & merge.
Thank you for detailed issue! :) --- According to the [docs](https://github.com/Kyslik/column-sortable#blade-extension): > `array()` parameter (3rd) is **default** (GET) query strings parameter Emphasis mine. So it is correct as it is,...
I fear that this will fix the issue you have but it may break the package use for others 😢 .
Maybe make it configurable but leave the default to ``?