adventure-platform icon indicating copy to clipboard operation
adventure-platform copied to clipboard

Update adventure to 4.14.0

Open Phoenix616 opened this issue 1 year ago • 3 comments

Did some (basic) testing and it seems to work just fine.

Phoenix616 avatar Jun 15 '23 15:06 Phoenix616

Adventure 4.14.0 has new APIs that need to be supported.

qixils avatar Jun 15 '23 20:06 qixils

Additionally, there is some newly-deprecated api in 4.14.0 that is relatively trivial to update for if you're able to do that

zml2008 avatar Jun 15 '23 20:06 zml2008

Adventure 4.14.0 has new APIs that need to be supported.

Someone more knowledgeable of the whole platform design might need to take a look at adding those features as I'm not quite sure how to implement those changes in the platform adaptors or how the adaptor design works in general. E.g. as far as I can tell net.kyori.adventure.bossbar.BossBar is never actually implemented anywhere by the facets or adaptors, only BossBar.Listener is. Is the idea to add methods to that? Then how would they be accessible from the normal API methods? Also would the FacetAudience need to implement BossBarViewer interface?


On an unrelated note to the PR (but which makes it harder for me to work on this): The overall code base is very hard to read for me as it uses 2 space indention and unfortunately I need more indention to properly differentiate code. (And of course hard-coded spaces as indention can not as easily adjusted to one's visual needs as tabs could :S)

EDIT: I love that I first try googling, don't find anything then after writing a bit about it end up finding a solution too. If anyone ever runs into similar issues, here is an InteliiJ plugin which solves that: https://plugins.jetbrains.com/plugin/14849-elastic-indents/

Phoenix616 avatar Jun 17 '23 15:06 Phoenix616