Kyle Maas
Kyle Maas
Just spotted another race condition we need to deal with. When live indexing is enabled, the indexing system runs two queries: a non-live query to pick up the old message,...
From what I can tell from reading through the Margaret code, there should be some kind of a processing/setter function which is called by Margaret for each message on each...
It runs on a Luigi pump without guarding. There's probably a similar race condition problem that the indexes have had.
See #261 Example test run: ``` 2023/01/29 02:41:11 [margaret/indexes/badger] overwrote batch limit 0 === RUN TestStartup 2023/01/29 02:41:11 saved identity @7yBz96Bmr/emsDSfugNa+1FQSG4+6SCFJ1Atw/6d3SI=.ed25519 to testrun/TestStartup/secret interop_test.go:123: go-sbot: @7yBz96Bmr/emsDSfugNa+1FQSG4+6SCFJ1Atw/6d3SI=.ed25519 level=warn t=52.390822ms unit=gossip event="live...
Related to #305, REUSE found some components which are licensed as AGPL-3.0-only. This is a little problematic because most of the rest of the project seems to be MIT, but...
Unclear on the difference in intended purpose between them. If someone could elaborate please, that would be helpful.
Just ran across this: https://github.com/ssbc/go-luigi/blob/324065b9a7c66588b6a42896de8da1b8cff6668d/stream.go#L52 We should probably figure out a way to test for this, detect it, and recover.
Looks like another race condition: ``` 2022/12/20 21:37:35 [margaret/indexes/badger] overwrote batch limit 0 === RUN TestNullFeed 2022/12/20 21:37:35 saved identity @feg0/jnGLq3efpsmjJKdl57ciUBp9MfTT0hP4MhKU3w=.ed25519 to testrun/TestNullFeed/main/secrets/arny 2022/12/20 21:37:35 saved identity ssb:feed/gabbygrove-v1/FjfVXOAz0UIHWiCye0CusyiYihBQio8dMshL6pR12kE= to testrun/TestNullFeed/main/secrets/bert...
See #237 ``` 2022/12/21 02:37:58 [margaret/indexes/badger] overwrote batch limit 0 === RUN TestBlocking 2022/12/21 02:37:58 saved identity @ulA/kpxMTZBo1ScyGzsZIZJVtSJKqmvpCIP4IROSLVM=.ed25519 to testrun/TestBlocking/secrets/alice 2022/12/21 02:37:58 saved identity @7PKY2sh4VVXMQo/Pdycds0BeBKxnOB9i1tURcI/rbQQ=.ed25519 to testrun/TestBlocking/secret interop_test.go:123: go-sbot: @7PKY2sh4VVXMQo/Pdycds0BeBKxnOB9i1tURcI/rbQQ=.ed25519...
See the failure in this test run while trying to track down #268: https://github.com/ssbc/go-ssb/actions/runs/3744726663/jobs/6358410184#step:9:406 What that means is that, in the absence of anything to prevent race conditions between operations...