one_second_diary icon indicating copy to clipboard operation
one_second_diary copied to clipboard

Published 20 hours ago • verified publisher icon KyleKun

Revamped notification service

Open ishanvaghani opened this issue 1 year ago • 2 comments

Description

Revamped Notification Service

  • Rewrote logic for scheduling/canceling/rescheduling notifications.
  • Notification permission flow handled.
  • Scheduling notification for next 2 weeks.
  • Canceling notification for that day after recording/uploading video.

Checklist

Before you create this PR, please confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x] I have added my name in the CONTRIBUTORS.md file, if it wasn't already present.
  • [x] I have added a description of the change in CHANGELOG.md.

ishanvaghani avatar Dec 30 '23 04:12 ishanvaghani

Hi @ishanvaghani , also, after changing to a profile and back to default profile, it schedule the notification for the day in a hour that has already passed (example: it is 5pm, the notification time in the settings is 10am, I changed the profiles and it scheduled for today at 10am.)

bianca7dev avatar Dec 30 '23 20:12 bianca7dev

@bianca7dev I have pushed one fix can you check notification is still coming after uploading video? secondly also check for changing profile still schedules invalid notification.

ishanvaghani avatar Dec 31 '23 04:12 ishanvaghani