typography.js icon indicating copy to clipboard operation
typography.js copied to clipboard

Published 20 hours ago • verified publisher icon KyleAMathews

Does it make sense to use it with reacstrap?

Open hanoii opened this issue 5 years ago • 5 comments

Is it OK to use both libraries or one would conflict with the other? reactrap needs the bootstrap css to work, which I take brings in fonts and stylings anyway.

hanoii avatar Jan 15 '19 14:01 hanoii

+1 I'm trying to use it with boostrap. For the most part, it works, but I have to do a lot of style hacking in order to prevent boostrap from overriding the styles from typography.js. See: https://github.com/gatsbyjs/gatsby/commit/5caf95e3029096ef722e676902c08813fc5176e7#r37034290.

fullofcaffeine avatar Jan 30 '20 07:01 fullofcaffeine

Hi, could any of the core members chime in to give some insights regarding this issue?

I'm currently using Bootstrap 4 + Typopgrahy.js (after going through a somewhat long process solve a related issue ) and while it works, there are clearly some small issues, mainly related to Bootstrap overwritting Typography.js rules or vice-versa. At the moment, I'm deliberately loading Typography.js after Bootstrap so that the fonts are actually set.

I think the main rationale for using both is twofold:

  1. Bootstrap is popular and well-known, it's a really productive framework after you get the hang of it (my case)

  2. Typography.js is really nice typeface-wise and the rules and themes save up a lot of time. Doing the same manually on Bootstrap (choosing fonts, overwriting typeface rules etc) would be very tedious.

So I think there's a huge potential here of using both together, but there's no mention of it anywhere in the docs :(

fullofcaffeine avatar Feb 05 '20 02:02 fullofcaffeine

This issue has been open for more than an year. I'm not expecting immediate answers from open-source maintainers - I'm one myself and I know how it is - but it's a long time for not having a reply. Is this project still being maintained or is this even the right forum for questions?

fullofcaffeine avatar Feb 06 '20 18:02 fullofcaffeine

@fullofcaffeine agreed! I am struggling to find the right setup to avoid bootstrap overwriting typography.js. the issue is still there to this day.

vincentreynaud avatar Jan 19 '22 08:01 vincentreynaud

@vincentreynaud Yeah, that's unfortunate. I managed to find a workaround but it was an ugly one. I don't recall exactly what it was now, but I'll try to refresh my memory soon and document here.

fullofcaffeine avatar Jan 25 '22 01:01 fullofcaffeine