typography.js icon indicating copy to clipboard operation
typography.js copied to clipboard

headerGray and bodyGray configuration keys don't work

Open gabdorf opened this issue 7 years ago • 5 comments

Hi,

The baseFontSize and scaleRatio work as intended but changing the headerGray and bodyGray values don't seem to do anything in the output

Maybe my syntax is incorrect? (also tried it with single quotes and percent symbols)

typography.js

import Typography from 'typography'

const typography = new Typography({
  baseFontSize: '21px',
  scaleRatio: 4,
  headerGray: 90,
  bodyGray: 90,
})

export default typography

gabdorf avatar Sep 28 '17 06:09 gabdorf

Yes, it's removed.

Ref: PR #94 & Issue #92

Use headerColor & bodyColor instead.

MunifTanjim avatar May 06 '18 15:05 MunifTanjim

http://kyleamathews.github.io/typography.js/ still lists them and has a demo of changing them. Thought I was crazy 😓

betaorbust avatar May 06 '18 18:05 betaorbust

He probably just forgot to update the demo page (that still uses an older build of typography.js) :sweat_smile:

MunifTanjim avatar May 06 '18 18:05 MunifTanjim

The demo page is still out of date. I discovered this only after spending a while trying to figure out where I was screwing up in my code. I now see that the up-to-date API doc is in the readme.

It would be nice to either remove the API documentation from the demo site or update it.

I can submit a pull request if I get some guidance since I'm not sure where one is supposed to make that change or how the demo page is generated.

raulrpearson avatar Oct 22 '18 07:10 raulrpearson

Hi.

The doc pages regarding this issue are still out of date, as of Jan/2020. I spent an unreasonable amount of time trying to figure out what I was doing wrong just to finally realize that the website was out of date...

It would be incredibly nice towards users to update the headerGray and bodyGray info on the website ;)

Thanks

bfreis avatar Jan 28 '20 02:01 bfreis