typefaces icon indicating copy to clipboard operation
typefaces copied to clipboard

Noto Sans TC implementation is not correct

Open gaplo917 opened this issue 5 years ago • 2 comments

import 'typeface-noto-sans-tc' compared with direct using

<link href="https://fonts.googleapis.com/css?family=Noto+Sans+TC:100,300,400,500,700,900" rel="stylesheet"/>

The traditional chinese characters didn't work as expected.

Example string: MacOS 用 RAM 用得好進取,所以愈多 RAM 愈好!


Using https://fonts.googleapis.com/css?family=Noto+Sans+TC:100,300,400,500,700,900 fontWeight: 900 Screenshot 2019-04-02 at 5 48 42 PM fontWeight: 300 Screenshot 2019-04-02 at 5 48 29 PM


Using import 'typeface-noto-sans-tc' fontWeight: 900 Screenshot 2019-04-02 at 5 46 58 PM fontWeight: 300 Screenshot 2019-04-02 at 5 46 34 PM

gaplo917 avatar Apr 02 '19 09:04 gaplo917

I looked through the source code. The Noto CJK packages are implemented in a way that only works for Latin characters set. It means that these packages won't work for the corresponding JP/KR/SC/TC character set.

This should be fixed by adding the japanese/ korean/ traditonal-chinese/ simplified-chinese files to the packages and changing the CSS.

NekoApocalypse avatar Apr 02 '19 14:04 NekoApocalypse

@NekoApocalypse seems like the author have some scripts to auto generate a package. But I cannot find it and then help in.

gaplo917 avatar Apr 03 '19 03:04 gaplo917