smart-contracts

smart-contracts copied to clipboard

block steps functions that create price raise

1

Too high rate due to cached rate: In case an exchange exists a reserve which has a (partially) increasing conversion rate in relation to the exchanged source quantity, then the...

ilanDoron

overflow possible in get Imbalance - very low likliehood.

1

In the getImbalance function, the multiplication totalImbalance *= resolution is performed unchecked. Since the resolution field can be arbitrarily big and totalImbalance can reach 2 63−1, overflows are possible. A...

ilanDoron

liquidity reserve might show 0 rates for both sides when exceeding price limits

2

would be better to only block one side.

yaronvel

For now y values at steps are fixed within the step range. The ability to set a y range within the step which would be either determined linearly or by...

aenaus

Unnecessary type conversions are introduced in the VolumeImbalance contract. In the addImbalance function, the argument uint currentBlock is passed and again cast to uint a few lines later. The same...

ilanDoron

Unable to set token wallet to reserve contract

2

Once token wallet is set, there is no way to set it to the reserve contract anymore. This is because token approval only happens in `approveWithdrawAddress`, and has the condition...

Anyhowclick