Rolling Loot Tables on WorldGen Thread is causing deadlocks

Open pietro-lopes opened this issue 8 months ago • 1 comments

Minecraft Version: 1.21.1 Mod Version: 1.3.4 Mod Loader: neoforge

Description: Server gets locked when generating chunks on deeperdarker dimensions

To Reproduce: Steps to reproduce the behavior: Generate chunks on Otherside with Immersive Engineering installed /execute in deeperdarker:otherside run neoforge generate start 0 0 0 50 true

at some point your server/game locks

Additional context: This is a deadlock caused by Deeper Darker + Immersive Engineering https://gnomebot.dev/paste/mclogs/53IPuC2

Worker-Main that got stuck: https://gnomebot.dev/paste/mclogs/53IPuC2#L1238

Deep and darker code: https://github.com/KyaniteMods/DeeperAndDarker/blob/3092bf3578250d45aa40afc8c20bdd67fa683221/src/main/java/com/kyanite/deeperdarker/content/blocks/entity/CrystallizedAmberBlockEntity.java#L33

Immersive eng code: https://github.com/BluSunrize/ImmersiveEngineering/blob/dcc0093cbf6522cbc96aa5f784330f8fc0556017/src/main/java/blusunrize/immersiveengineering/common/util/loot/LootBlockStateFromLocationPredicate.java#L57

Apr 17 '25 17:04 pietro-lopes

Fixed for neoforge. Will ship it with v1.3.5 in this coming week.

Apr 21 '25 06:04 NewJumper