DeeperAndDarker icon indicating copy to clipboard operation
DeeperAndDarker copied to clipboard

[1.20.1] Armor material to store repairIngredient as Lazy

Open KreloX opened this issue 9 months ago • 2 comments

Description: DDArmorMaterials and DDTiers should store repairIngredients as Lazies or LazyLoadedValues. Currently, if another mod tries to add compatibility and uses this mod's materials, the game crashes because the repair items' registry objects are not loaded yet. Also it would be better to use tags instead of direct item references for better data pack support.

KreloX avatar Mar 08 '25 08:03 KreloX

I found the crash can be avoided from the other end, but with the lazy value it would not be an issue in the first place. And the data pack support would be welcomed regardless, and that's for the latest version too, not just 1.20.1.

KreloX avatar Mar 08 '25 09:03 KreloX

fixed in neoforge a27ad9a

NewJumper avatar Mar 10 '25 21:03 NewJumper