rkdb icon indicating copy to clipboard operation
rkdb copied to clipboard

Consider using tidyverse/hms for time type

Open sv opened this issue 6 years ago • 3 comments

https://hms.tidyverse.org/index.html

sv avatar Sep 13 '18 19:09 sv

What does that bring over difftime ? What precision do we need ?

statquant avatar Sep 16 '18 21:09 statquant

We need up to millisecond for time. integer is enough for this. In current master it converts just to vector of ints. In my branch I have it as POSIXct: which is has date in it and timezone.
difftime has unit only up to seconds, which is not suitable. hms is based on difftime and can go up to microseconds according to description and can play with posixct, be nagative or more then 24hrs

sv avatar Sep 16 '18 21:09 sv

Is this still open? The nanotime package has a nanoduration class which would be better suited I think. It handles nanoseconds and is using integer64 under the hood

statquant avatar Jan 16 '21 10:01 statquant