operating icon indicating copy to clipboard operation
operating copied to clipboard

Exclude Include pod

Open ColdsteelRail opened this issue 1 year ago • 1 comments

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • [ ] N
  • [x] Y #245 #105

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [ ] N
  • [ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Benchmark (add benchmark stats below)
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ColdsteelRail avatar Aug 27 '24 02:08 ColdsteelRail

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.21%. Comparing base (a91ffd8) to head (09eac01). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/collaset/collaset_controller.go 33.33% 4 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   66.06%   66.21%   +0.15%     
==========================================
  Files          78       79       +1     
  Lines        5681     5739      +58     
==========================================
+ Hits         3753     3800      +47     
- Misses       1574     1579       +5     
- Partials      354      360       +6     
Flag Coverage Δ
unittests 66.21% <89.83%> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '24 06:08 codecov[bot]

lgtm, cc @zoumo

Eikykun avatar Oct 29 '24 02:10 Eikykun