Adrian Hassan Abdala

Results 9 comments of Adrian Hassan Abdala

I see these tests failing on OSX, I will address this by first attempting to read the store using x509.SystemCertPool() call to basically test if I am on Windows or...

Apologies for the bad initial request. Testing was passing locally, but failed in travis due to OSX throwing errors with the windows specific syscall methods. Tests are now passing with...

It isn't just the other PR that is failing CI, the whole project failed for the `go: master` configuration since the latest commit 7e96b8b53e6fd45c9f9435ccd57ca102dba7eb06.

@ptoomey3, the failing Travis tests are not due to any issue with the changes contained in this PR. Unit tests are passing on the 1.12 and 1.14 golang configurations in...

As soon as https://github.com/github/smimesign/pull/69 gets pulled in, I'll update this branch so CI will be passing. Can I get an estimate since getting the Windows root store fix is important...

Thank you @lgarron! All unit tests passing

Can I get a quick update on this? It's been a few months

Thanks for the review @vcsjones. I have addressed your concern about unreliable enumeration of the windows root store in the following way. I used gocertifi to initialize the CertPool and...

Been a few months. Can I get a checkup on this?