react-native-side-menu icon indicating copy to clipboard operation
react-native-side-menu copied to clipboard

isOpen has a defaultProp of false, which breaks componentWillReceiveProps's logic

Open ckknight opened this issue 8 years ago • 0 comments

As per https://github.com/react-native-community/react-native-side-menu/blob/master/index.js#L114,

The first check of typeof props.isOpen !== 'undefined' is always guaranteed to be false, as isOpen cannot be set to undefined, as that is being overridden by defaultProps which coalesces undefined to false.

ckknight avatar Jul 20 '17 19:07 ckknight