KeePassDX
KeePassDX copied to clipboard
Kunzisoft
Download icon
Related to #596.
- Adds a new "Download" button in the right side of the URL field.
- Uses DuckDuckGo's favicon API to search and download the favicon based on the URL.
- Downloaded favicon is saved to local database. It also avoids duplicated icons if they have been downloaded previously using this functionality.
Thanks for your pull request but there is a problem. KeePassDX was created to not have internet permissions so I can't integrate it like this (that's why I created the icon download system from the website instead).
Ideally, it should be an extension and the user should be informed during installation that it will add network permissions.
That's possible to do, but I don't know how you would like to maintain it because it would need to be a new app (with just a service) uploaded to the Play Store.
I could extract the download logic to a new app and see if it works for you 🤔
In my mind, if this functionality is integrated it would be an APK to download from github with a link from the app, I don't want to manage separate plugins on the play store. If you want to extract the logic, yes if you want, right now I'm on other topics so I'll look in detail later.
I would be against this as favicon attacks are becoming more common. And as main dev mentioned, no internet permission and it should stay that way.
As a temporary solution, why not include a bundle of favicons in the app itself from common websites just like andotp app? While saving the credentials, the app must also smartly choose the favicon based on the url domain if available in database...
Good idea, we can also imagine creating a community github repo where users could add their favicons to a database (of favicons) that could then be loaded directly into keepassdx (this would avoid having to download a large number of favicons via the keepassdx website)
I had thought about it and even made an implementation with the smallest possible svg but it still makes the APK a lot heavier (with raster images, it takes even more space), so a bundle of icons must to be done by plugin in order not to weigh down the application. I had tried by making a script with the source code of Google which allows to convert SVG (https://github.com/simple-icons/simple-icons) to Android vectors but I also had problems because there were way too many vectors on some images (so made empty images to convert manually). Finally I gave up and makes the website more maintainable. It is possible for someone who is super motivated but it will be also necessary to maintain the package with constant new icons, so have to make another script that will extract them from the repository to create the plugin.
Ok in that case is it not possible to use system installed icon packs to pick the image like how launchers are using?
That's a good question, I honestly don't know. I would need some sample code to see if the launchers have special permissions and how the icon packs are stored but I think they are just icons uploaded to the launcher space so it's like making icon plugins.
The main problem for me is the number of icons, because there will be more and more and I don't want to favor big services by choosing the most popular ones and not the new ones which can be very legitimate too.
And the more there are, the more maintenance it requires. From memory, there were more than 2000 icons during my tests with SVGs, it made Android studio crash even if they are small files. In addition, we have to make an efficient search system which is much more complicated to do with Android than in javascript with Angular.
I found aegis app, the open source authenticator which is built on same principal local storage is using icon pack feature to add the icons...maybe same can be used here
https://github.com/aegis-icons/aegis-icons/blob/master/FAQ.md#with-icon-pack
@sheikh-azharuddin Yes, the implementation of Aegis is quite good for this situation, I hope he will consider it in the nearest time possible.
And thank you for the wonderful app.
