KunstmaanBundlesCMS icon indicating copy to clipboard operation
KunstmaanBundlesCMS copied to clipboard

Replace kunstmaan/google-api-custom with official google package

Open acrobat opened this issue 4 years ago • 3 comments

Currently we're using a custom fork of the google api php client, but this package is lagging behind on the official package and users can't install the google package next to it because of conflicting namespaces. Try to remove the kunstmaan/google-api-custom package and depend on the google/apiclient package instead.

acrobat avatar Oct 07 '20 07:10 acrobat

Hi, I would just like to vote for this issue!Any ideas on what is needed to be done?

tarjei avatar Jan 30 '21 08:01 tarjei

A few thing are needed here:

  • Replace kunstmaan/google-api-custom package with google/apiclient and see what the incompatibilities are.
    • Check which bc breaks there are and if we can change the code in a way to support both libs but deprecate the old one.
  • Most of the implementation changes will need to change in the dashboard bundle (the google analytics widget)

So as a first step we need to get an overview of places in the code that need changes and if we can do these changes without breaking BC

acrobat avatar Feb 01 '21 07:02 acrobat

Related to #3245

acrobat avatar Feb 09 '23 11:02 acrobat