Kunena-Forum icon indicating copy to clipboard operation
Kunena-Forum copied to clipboard

depricated seterrors on libraries

Open 810 opened this issue 9 years ago • 16 comments

Steps to reproduce the issue

$this->setError(.. libraries\kunena\forum\message\message.php

Expected result

Actual result

System information (as much as possible)

Joomla version: Kunena version: Php version: Database version:

Additional comments

810 avatar Sep 06 '16 20:09 810

This setError() method seems to come from JObject, then the JObject class is deprecated too

xillibit avatar Sep 06 '16 21:09 xillibit

There is no class to replace it. JObject is a historic class which isn't really needed anymore with current PHP versions.

The error handling should instead be done using exceptions.

810 avatar Sep 06 '16 21:09 810

I had understood that, the JObject class will be removed in Joomla! 4.0 and some Kunena classes extend JObject so i'am afraid that it will will cause some issues into Kunena. For now we will have a bit of time before Joomla! 4.0 will be released

xillibit avatar Sep 07 '16 13:09 xillibit

i have changed the milestone to 5.1.

there are 5 files that is using the object now

810 avatar Sep 07 '16 15:09 810

I will start by removing setError()calls then i will look to remove usage of JObect

xillibit avatar Sep 07 '16 17:09 xillibit

This one isn't finished, i had done a part but no all.

xillibit avatar Sep 17 '16 14:09 xillibit

Currently status: 391 deprecations

Inspection report: https://www.kunena.org/logs/deprecated/index.html

810 avatar Oct 05 '16 00:10 810

Currently status: 436 deprecations

810 avatar Jun 11 '17 16:06 810

Currently status: 408 deprecations on J3.8 B1

810 avatar Aug 14 '17 14:08 810

Currently status: 129 deprecations on J3.8 rc2

810 avatar Sep 10 '17 15:09 810

255 deprecations on J3.8.1

810 avatar Oct 07 '17 00:10 810

j4 690 weak warnings

810 avatar Mar 02 '19 22:03 810

Currently status: 679 deprecations on Kunena 6.0.0-BETA3-DEV-GIT

810 avatar Oct 02 '21 20:10 810

Currently status: 382 deprecations on Kunena 6.0.0-BETA4-DEV-GIT

810 avatar Nov 09 '21 23:11 810

Currently status: 385 deprecations on Kunena 6.0.0-BETA4-DEV-GIT

810 avatar Dec 17 '21 23:12 810

Currently status: 405 deprecations on Kunena 6.0.0-RC1-DEV-GIT

810 avatar Feb 02 '22 01:02 810