ublox icon indicating copy to clipboard operation
ublox copied to clipboard

Humble support

Open samiamlabs opened this issue 2 years ago • 2 comments

Hi!

The galactic-devel would not build for me on ROS2 Humble.

Updating to the new macro for linking to interfaces generated in the same package seems to have fixed it.

include_directories(include)
add_library(${PROJECT_NAME}_lib src/ublox_msgs.cpp)
- rosidl_target_interfaces(${PROJECT_NAME}_lib ${PROJECT_NAME} "rosidl_typesupport_cpp")
+ rosidl_get_typesupport_target(cpp_typesupport_target ${PROJECT_NAME} "rosidl_typesupport_cpp")
+ target_link_libraries(${PROJECT_NAME}_lib "${cpp_typesupport_target}") 
ament_target_dependencies(${PROJECT_NAME}_lib
  "ublox_serialization"
)

I have a branch with the fix here https://github.com/samiamlabs/ublox/tree/humble-devel

There is currently no humble-devel branch in this repo to open a PR to though.

samiamlabs avatar Jul 29 '22 12:07 samiamlabs

Just created the branch. Could you please submit your PR?

fcladera avatar Aug 02 '22 19:08 fcladera

Sorry about the slow response, was on vacation last week. PR is up here now: https://github.com/KumarRobotics/ublox/pull/178

samiamlabs avatar Aug 08 '22 09:08 samiamlabs

This is already fixed on the ros2 branch, so no changes should be needed. Closing this out, but feel free to reopen if you disagree.

clalancette avatar Sep 07 '22 12:09 clalancette