kucoin-php-sdk icon indicating copy to clipboard operation
kucoin-php-sdk copied to clipboard

Order remark

Open RCTORONTO opened this issue 4 years ago • 4 comments

"done" and "filled" order updates received via websocket feed do not contain the order remark.

RCTORONTO avatar Aug 20 '21 07:08 RCTORONTO

The remark field is a non-transactional core field. Based on the consideration of delivery performance, this remark field is not included in the order push message

codewc avatar Aug 20 '21 12:08 codewc

Our application uses the remark to store information about that orders previous one - to know if it's reciprocal or a new one, not including that one little tidbit of information means we will have to make an additional call to the API to retrieve it. NOT IDEAL. Also "createdAt" should really remain "createdAt" throughout, when you start changing names of things I.E. "createdAt" suddenly becomes "orderTime" it's really makes for confusion. It's pretty obvious this API and feed were written by different people at different times....

RCTORONTO avatar Aug 20 '21 18:08 RCTORONTO

Our application uses the remark to store information about that orders previous one - to know if it's reciprocal or a new one, not including that one little tidbit of information means we will have to make an additional call to the API to retrieve it. NOT IDEAL. Also "createdAt" should really remain "createdAt" throughout, when you start changing names of things I.E. "createdAt" suddenly becomes "orderTime" it's really makes for confusion. It's pretty obvious this API and feed were written by different people at different times....

Brother, regarding the remark requirement mentioned, just like you said, you need to query it again through the API, or you can maintain the corresponding relationship with the database locally. This is very inconvenient, but remark will also take up network traffic, so after comprehensive consideration, we decided not to return remark in the message

Regarding the phenomenon that the fields are not uniform or easy to be confused, I think you make a lot of sense. It is necessary to avoid this situation in the future.

codewc avatar Aug 21 '21 01:08 codewc

alright, we'll sort it by a separate call to get order by clientOid... thanks for the reply

RCTORONTO avatar Aug 21 '21 16:08 RCTORONTO