kuadrant-operator icon indicating copy to clipboard operation
kuadrant-operator copied to clipboard

Enable gateway api alpha APIs

Open eguzki opened this issue 2 years ago • 1 comments

What

Enable Gateway API alpha APIs for the development environment. It is mandatory for testing current alpha APIs like GRPCRoute API.

Verification steps

Istio operator

make local-setup

When finished, check the discovery controller has PILOT_ENABLE_ALPHA_GATEWAY_API env var set to true

kubectl get deployment istiod -n istio-system -o jsonpath='{.spec.template.spec.containers[?(@.name=="discovery")].env[?(@.name=="PILOT_ENABLE_ALPHA_GATEWAY_API")]}' | yq e -P

Should return

name: PILOT_ENABLE_ALPHA_GATEWAY_API
value: "true"

Sail operator

ISTIO_INSTALL_SAIL=true make local-setup

When finished, check the discovery controller has PILOT_ENABLE_ALPHA_GATEWAY_API env var set to true

kubectl get deployment istiod -n istio-system -o jsonpath='{.spec.template.spec.containers[?(@.name=="discovery")].env[?(@.name=="PILOT_ENABLE_ALPHA_GATEWAY_API")]}' | yq e -P

Should return

name: PILOT_ENABLE_ALPHA_GATEWAY_API
value: "true"

eguzki avatar Feb 15 '24 17:02 eguzki

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.29%. Comparing base (c831a70) to head (53171a3). Report is 557 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   66.49%   65.29%   -1.21%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2594     2547      -47     
- Misses       1123     1158      +35     
- Partials      184      196      +12     
Flag Coverage Δ
integration ∅ <ø> (∅)
unit ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) ∅ <ø> (∅)
pkg/log (u) ∅ <ø> (∅)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) ∅ <ø> (∅)

see 6 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 15 '24 17:02 codecov[bot]

Should this be closed @eguzki

maleck13 avatar Nov 14 '24 10:11 maleck13

Yeah, not a priority now.

eguzki avatar Apr 08 '25 15:04 eguzki