angular-modal-gallery icon indicating copy to clipboard operation
angular-modal-gallery copied to clipboard

Zoom into currentImage on touch devices...

Open Monarch73 opened this issue 5 years ago • 5 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[X] Support request

Current behavior

Current Image is not zoomable on touch devices.

Expected behavior

I would like to have the user to be able to zoom into the currentImage on touch devices (smartphones)

Minimal reproduction of the problem with instructions

My official live example on StackBlitz (based on https://stackblitz.com/edit/angular-modal-gallery-v5) is:

What is the motivation / use case for changing the behavior?

I am using the gallery component to display images containing texts. If the images get scaled down to much, I would like to have the option to zoom into the image.

Environment (the most important section to fill very carefully)


- Node version: 10.9.0.0  
- npm version: 6.4.0 
- Operating System and version: Windows  
- Angular version: 6.1.0 
- angular-cli version (or SystemJS/Webpack):  6.1.1 
- I'm using Server Side Rendering with angular-universal: NO
- I'm compiling with mode: DEBUG / PROD / PROD with AOT



Browser:
- [ ] Chrome (desktop) version XX
- [X] Chrome (Android) version (most recent)
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX


Others:

Monarch73 avatar Aug 28 '18 08:08 Monarch73

Thank u, I'll confirm the issue. I'll investigate tomorrow.

Ks89 avatar Aug 28 '18 11:08 Ks89

Ok I checked and it's something related to Hammer js. I'll try to fix it this weekend because I'm quite busy right now. It's the first week after my holiday

Ks89 avatar Aug 29 '18 06:08 Ks89

Mille Grazie for looking into this. Much appreciated. If there is anything I can do to support you on this, please don't hesitate to let me know...

Monarch73 avatar Aug 29 '18 09:08 Monarch73

Hi, I investigated but It's more complicated than expected, because It's not something that I'm managing directly, but with hammerjs. I opened an issue here https://github.com/hammerjs/hammer.js/issues/1193 into the official hammerjs repo to ask more information about this behaviour. Please be patient. I'll update the issue when I'll find a solution.

Ks89 avatar Sep 01 '18 00:09 Ks89

I removed hammerjs on develop branch #218 because abandoned since 2016. If someone want to help me with this, feel free to create pull requests

Ks89 avatar Mar 29 '23 11:03 Ks89