Robert Adam
Robert Adam
> implement an option to (re-)enable the notification No. We won't start a war with package maintainers here. > Implement a new option like I proposed above (let's call it:...
> In my impression the "makro" (as you called it) is understood as "disable auto-notification", not "disable the ability of the user to enable notification". In fact when checking the...
That's a valid point (which I agree that disabling it by default is a good choice here). But if a user wants to know, I don't see a justification to...
As I see it, the test is back in place...
Presumably this class relies on something like the size of an integer being exactly x bytes or something like this :thinking:
I fail to see why this would be a problem other than perhaps causing compiler warnings. But to my understanding signed and unsigned char should be of the exact same...
How does https://github.com/mumble-voip/mumble/blob/73d8a4d5dbd2c45bd141518bb8b9a2ad796fde1f/src/PacketDataStream.h#L143 really check for the _type_ of the variable passed? I would have interpreted as if it was merely checking whether the first bit is set, which afaik...
I still fail to see how the issue can be in the variable's _type_. We're only testing its binary layout (the set bits) and afaik that doesn't change between signed...
ATM there is no way around it. But there is already a ticket about weakening the disabling of shortcuts on Wayland.