Paweł Zakrzewski

I think I need to educate myself about this before offering an opinion. I expect I'll have the time to look at this next week.

It's a very good point. Thanks for bringing that up. I'm on it.

> I remember you also had a UT for this change, can you add it here as well? This function is only available from within this TU.

> I think we're missing a case when someone provides generic `replication_factor` tag in ALTER KS statement and only handle a case where every DC with its RF is stated...

At this point I don't know if the second commit needs to be there. Probably not.

Rebased the code and changes on #17846, my changes are on top of Benny's

> I don't understand the motivation for this PR. reallocate_tablets_for_new_rf wraps reallocate_tablets but it isn't used here except for the additional unit tests. How is it integrated with the higher...

The changes have been cherry-picked by @ptrsmrn in #16723

We can do this. There are 2 scenarios to consider: - you do have a C++ compiler available, then you can make a separate compilation unit (a .cpp file) that...

Is it possible that you're building crashpad without openssl-dev available? That's the most likely to cause https being unsupported.