Blog_Website icon indicating copy to clipboard operation
Blog_Website copied to clipboard

Published 20 hours ago • verified publisher icon Kritika30032002

[feat] Added in blog-site

Open PranjaliBhardwaj opened this issue 11 months ago • 7 comments

#108 #152 all overlapping of footer from all pages are fixed and signup with google OAuth credentials is also added in the signup page, After: Screenshot 2024-03-22 170754 Before: Screenshot 2024-03-22 124216 I have removed firebase config details due to security reasons, but I am also beginner and don't know if its okay, so if it is I can add those details too. @Kritika30032002

PranjaliBhardwaj avatar Mar 22 '24 17:03 PranjaliBhardwaj

adding
for space is not a good practice. Look into another way.

Kritika30032002 avatar Mar 23 '24 03:03 Kritika30032002

also you should have separate pr for separate issue

Kritika30032002 avatar Mar 23 '24 03:03 Kritika30032002

@Kritika30032002 That issue wasn't that big so I didn't create a new pull request, but for future I will keep that in mind. I have used css now to avoid overlapping of footer and other page's content.

PranjaliBhardwaj avatar Mar 23 '24 17:03 PranjaliBhardwaj

image

see the highlighted code line

Kritika30032002 avatar Mar 24 '24 15:03 Kritika30032002

image

see the highlighted code line

So I should use margin instead to spaces?

PranjaliBhardwaj avatar Mar 24 '24 17:03 PranjaliBhardwaj

yes

Kritika30032002 avatar Mar 24 '24 20:03 Kritika30032002

now its good. @Kritika30032002 Thankyou for your guidance and patience.

PranjaliBhardwaj avatar Mar 25 '24 11:03 PranjaliBhardwaj