Kristoffer Carlsson comments

Results 1634 comments of


                                            Kristoffer Carlsson

Assume :nothrow in iterating over tuples

Is is also valid to annotate `iterate` for `Array` with this?

An intrinisic/function/macro like assume

Wouldn't it be possible to have a (debug) mode where the assumptions are checked?

Type instability with `Base.promote_type` and Static.jl types for Julia v1.10-beta2 and `--check-bounds=no`

Talking with @Keno, it seems that this cannot really be fixed in 1.10 and has to wait for 1.11, see e.g. https://github.com/JuliaLang/julia/pull/50641. So I will take this off the milestone.

Constructing a 67108864 TiB array succeeds incorrectly, corrupting memory

What does "UB" mean here (the UB bug really bit people...). This is just a bug.

v1.11 Takes longer to compile, generates 50% larger cache files and loads slower

Would be interesting to put back all stdlibs into the sysimage and re-time this to see if the effect is purely for moving out stdlibs or if there are other...

v1.11 Takes longer to compile, generates 50% larger cache files and loads slower

As you showed in https://github.com/quinnj/JSON3.jl/issues/279, the issue there seems to be egregious use of `@inline` on large functions. It isn't obvious why that would change between 1.10 to 1.11 but...

v1.11 Takes longer to compile, generates 50% larger cache files and loads slower

This seems to be more or less fixed on 1.11 backport branch. This is using the master branch of GMT.jl: ```julia julia> @time using GMT 0.638436 seconds (668.47 k allocations:...

v1.11 Takes longer to compile, generates 50% larger cache files and loads slower

1.11: ``` Contents of /Users/kristoffercarlsson/.julia/compiled/v1.11/GMT/EoU0j_u25Qm.dylib: modules: Any[GMT.Gdal, GMT.Drawing, GMT] init order: Any[GMT.Gdal, GMT] 1503 external methods 22730 new specializations of external methods (Base 80.0%, Base.Broadcast 14.5%, Base.Iterators 2.5%, ...) 1371...

Dont print info by default

Debug probably also works, but I am not very familiar with the Base Logging system.

Mutating functions re-use their arguments

FWIW, there was a recent talk at CppCon by Chandler Carruth where he demonstrates some interesting micro benchmarks problems precisely by benchmarking `push_back`, see https://youtu.be/nXaxk27zwlk?t=924 The way he does it...