Kristoffer Carlsson

Results 1634 comments of Kristoffer Carlsson

Can this be updated, merged and bumped on `backports-release-1.9`?

> Just create a merge commit. Yes > With the bot? Just do it manually. Update the hash in `stdlib /SparseArrays.version`. Also, should probably remove nightly CI from this branch...

I think the core problem is that you cannot change between float32 and float64 support in suitesparse during runtime. Edit: Actually https://github.com/JuliaLang/julia/issues/14076#issuecomment-158998239 says that it's not even supported.

Currently, you need to use the fields to do almost any efficient sparse matrix manipulations. So they are de facto public.

I think it is quite fundamental to a lot of the sparse code that this "neutral" element acts like a zero in the sense of `neutral(x) + x = x`...

> Common knowledge sounds wrong then Ref https://github.com/JuliaLang/julia/issues/9755

I haven't really kept up with the changes in LinearAlgebra so I am not super qualified to look at this. But overall it looks good. I'm happy to make you...

Did you figure out what caused the previous mac error (considering CI is now green)?

Yeah, that's true. An alternative would be for the sparse matrix multiplication API to let you set a "backend" that does the computation. Basically, separate the concept of sparse matrix...

> In fact, I see this instance of type piracy as the one situation where type piracy is desirable Well, what happens if there is another package that provides sparse...