Kristoffer Carlsson

`y[2]` is a function call that occurs later than the rest which is why that get picked. I guess `sl` could be special cased to ignore `setindex!`.

> aiming to replace the widespread use of `const` to improve the performance of globals I don't get it. Why replace const? `const` is stricter than a typed global and...

Just saying, the premise that this PR seems to build on (trying to replace consts with non-consts) is not gonna fly very far. I would suggest making it solely about...

It would be cute if this could be written as something like `x::auto = y`. It just feels like the big `@typeconst` becomes so "overwhelming" here compared to what it...

There is also matrix checkers: https://github.com/JuliaSparse/Pardiso.jl#matrix-and-vector-checkers. > In MKL PARDISO this is instead done by setting IPARM[27] to 1 before calling pardiso. You might want to try that.

> why isn't latest QML tested with all latest dependencies, such as CxxWrap, by PkgEval? Because of https://github.com/JuliaGraphics/QML.jl/blob/8dc510d4d7ebaebc9a18ca1d927b88f6745137d7/Project.toml#L18

That's a good idea! There used to be a "debug" mode that you could activate that added some stats but it was removed in https://github.com/KristofferC/NearestNeighbors.jl/pull/98/files#diff-3d112593fe19c53f85f19846cc9d0406c17b39736378b65e7d12821d20207302. With more experienced eyes, I...

NearestNeighbors uses StaticArrays which is built on top of tuples which has compilation time issues when they get very big. > adapt the claim "perform high performance nearest neighbor searches...

> I'm running into this issue too. I've got ~1600 dimensional features. There's not really a good reason to use StaticArrays past certain size IMO. True but there is probably...

One potential issue with this is that `getindex` is slower on AoA so depending on how people use the return value they might encounter performance regressions.