Crayons.jl icon indicating copy to clipboard operation
Crayons.jl copied to clipboard

correctly overload 3 arg show

Open KristofferC opened this issue 5 years ago • 1 comments

Looking back at this I think this is how you are supposed to do it. Would be good to see if this is breaking for how packages use this.

KristofferC avatar Sep 14 '20 11:09 KristofferC

Codecov Report

Merging #43 into master will decrease coverage by 2.23%. The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   88.25%   86.02%   -2.24%     
==========================================
  Files           8        8              
  Lines         298      322      +24     
==========================================
+ Hits          263      277      +14     
- Misses         35       45      +10     
Impacted Files Coverage Δ
src/downcasts.jl 93.54% <50.00%> (+0.44%) :arrow_up:
src/crayon_stack.jl 95.65% <66.66%> (-4.35%) :arrow_down:
src/crayon_wrapper.jl 58.33% <72.72%> (-33.98%) :arrow_down:
src/crayon.jl 89.47% <85.71%> (+0.28%) :arrow_up:
src/logo.jl 100.00% <0.00%> (ø)
src/macro.jl 83.33% <0.00%> (+0.43%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e673f7...8f5de99. Read the comment docs.

codecov-commenter avatar Sep 14 '20 14:09 codecov-commenter