Krishna comments

Results 355 comments of


                                            Krishna

[$250] Chat - Most of the workspace modifying settings messages are not translated in #Admins

@rushatgabhane, you can start reviewing the PR. Half of the translations have been added, and I will ask for translation verification on Slack today. However, I'm not sure what should...

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

I will work on unit test tomorrow.

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

@s77rt, added the unit tests.

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

> The test unit should fail if we remove the !isFocused from WorkspaceSwitcherPage @s77rt added a test for this case.

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

@s77rt, Sorry for all the trouble I’ve caused. I’m writing UI tests for the first time and was trying to follow [this file](https://github.com/Expensify/App/blob/7bfb34527508b47732cab6d4280a943ffab48066/tests/perf-test/SelectionList.perf-test.tsx#L1). Could you please guide me with some...

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

I'm working on writing the tests and will probably update them today.

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

> The MockedSidebarLinks is missing the @s77rt, will try to finish this today, I added `TopBar` in `MockedSidebarLinks` and since then I'm facing multiple errors. > TypeError: Cannot read properties...

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

I'm sorry for the delay 🙏🏻. I'm currently stuck in a loop of errors while writing tests, and it's taking longer than expected. This is the first time I'm writing...

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

Will start woking on this again in a hour. Thanks @s77rt for the help 🙇🏻❤️

fix: mWeb - Selector - User lands on the same WS when double tapping on different one on selector.

@s77rt, when I try to simulate multiple presses in a quick session, the tests throw this error: ![image](https://github.com/user-attachments/assets/bfdd5936-17e2-4dc8-ae01-c79f3a09af4e)