Krishna comments

Results 370 comments of


                                            Krishna

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

@blimpich @thesahindia, @GandalfGwaihir added the note below which I don't think makes sense and I think they are just confusing in the name of `unnecessary function call and redundant`. `ErrorUtils....

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

@GandalfGwaihir, please refrain from using the 👎 emoji as it is very annoying and would not help justify your duplicate proposal. If you have any valid reasons, please do reply...

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

@GandalfGwaihir, I think you need to look at the form guidelines. Thats the reason why we use `ErrorUtils.addErrorMessage` in `NewTaskTitlePage.tsx`. https://github.com/Expensify/App/blob/3d780639eb260c1165e884032f4a92aa7dbbb4ca/contributingGuides/FORMS.md?plain=1#L154-L174

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

We are validating `title` twice. There is a reason why we use `ErrorUtils.addErrorMessage` in `NewTaskTitlePage.tsx`. https://github.com/Expensify/App/blob/c915e7f026eddc710dd01a38abc3afc9334002ae/src/pages/tasks/NewTaskTitlePage.tsx#L38-L49 Let me know if you want more examples, we even use `ErrorUtils.addErrorMessage` where we...

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

> sorry but i won't be able to explain further after this Because you don't have a valid point. We are using `ErrorUtils` in `NewTaskTitlePage` and there is no such...

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

In both `TaskDescriptionPage` & `NewTaskDescriptionPage`, we don't even validate description twice but still we use `ErrorUtils.addErrorMessage`. All I wan't to say is that using `ErrorUtils.addErrorMessage` doesn't have a downside and...

[$250] Task - No error of exceeding limit when changing title of existing task & system message posted

@blimpich, sorry for that but I was literally annoyed by 👎 reactions of the contributor when I was only asking C+ for a second look.

Workspace - The new WS names appear in English when Spanish is set up

Edited by **proposal-police**: This proposal was **edited** at 2024-12-05 01:16:03 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. Workspace - The...

Workspace - The new WS names appear in English when Spanish is set up

@MonilBhavsar, it's mostly translations addition, I don't think we ever add automated tests for translations. Additionally, the other proposal does not even talk about the regex update which is a...

Workspace - The new WS names appear in English when Spanish is set up

> Are you talking about this? What kind of addition did you make in the proposal? What I see in your pseudocode is that you might have broke the numbering...