Krish Patel

Results 44 comments of Krish Patel

Finally fixed all checks and test :-)

> @KrishPatel13 is this ready for re-review? I have not completed this yet. I will let you know. I have add WebSockets creation and connection in openadapt package now and...

@abrichr Just wanted to clarify that we want to include the chrome browser events in the main db (openadapt.db) right ? Or Is it fine we have a seperate db:...

Alright on it right now! Thank you clarifying.

@abrichr Do you know how to fix this error: ![image](https://github.com/OpenAdaptAI/OpenAdapt/assets/65433817/2b610134-560f-4111-9061-991fa093ad8a) There are many int type variable in config.py, there should be something where I am going wrong: ![image](https://github.com/OpenAdaptAI/OpenAdapt/assets/65433817/fede7ad9-798d-4d1d-83fd-a3e085c5ca1c) Thank you

To test overall follow these steps: 1. Go To: [Chrome Extension Page](chrome://extensions/) 2. Turn on the `Developer mode` to on (near top right): ![image](https://github.com/OpenAdaptAI/OpenAdapt/assets/65433817/c97eb9fb-05d6-465d-85b3-332694556272) 3. Click on `Load Unpacked` (near...

> Excellent work @KrishPatel13 ! I left a few comments, happy to chat about any of it if you like 😄 Thank you !! > Edit: can you please also...

For this comment: https://github.com/OpenAdaptAI/OpenAdapt/pull/744#discussion_r1668785377, Resolved/done here: fa9e458a6214cd16fc1d5f1848a5c72355e48d70

@abrichr I have addresses all of your comments. Before merging, it will be great if we could test this on MacOS. I will test this again later this week on...