CentOS support, logstash::config as a PC, redis support..

[simonmcc]

All my changes layered on top of your most recent commit. CentOS & Debian/Ubuntu support Replaced logstash::common with logstash::config, which is a parameterised class Split logstash into 3 roles, with matching classes (logstash::shipper, logstash::indexer & log stash::web) Added a templated java init script Trampled over your Modulefile to lazily keep applying my patches Some examples in README.md (replaced your README, sorry!) Use redis as transport, optionally install/configure via logstash::redis Added support for pulling log stash jar over http (or puppet or package)

[KrisBuytaert]

There's a bunch of things I like about this approach . there's a couple of things I don't :)

Let's start with the stuff I don't like :) First , I don't thik a redis config belongs in a logstash module, it belongs in a redis module. Secondly .. I`m using Java Service wrapper to launch all java services .. your init scripts kinda don't mix with those ..

I do however like the way you approach multiple functionalities in logstash, my current approach is pretty limited and I was thinking about how to add support for more input/filter/output configs.

Need to thinker a bit on how to merge this .. :)

[simonmcc]

Let's start with the stuff I don't like :)

First , I don't thik a redis config belongs in a logstash module, it belongs in a redis module.

Agreed - that was just me being lazy & trying to manage all the required dependencies in one place. 2 options IMHO:

1. just config logstash to use redis or amqp
2. 1 + optionally depend on an external redis module to pull in a suitable redis server?

Secondly .. I`m using Java Service wrapper to launch all java services .. your init scripts kinda don't mix with those ..

I had a quick look at the Java Service Wrappers - they seemed like a real pain to get all the dependencies on CentOS/OL (at least for 5.x), do you have a better experience of that?

We could make the init script choice a configurable item?

I do however like the way you approach multiple functionalities in logstash, my current approach is pretty limited and I was thinking about how to add support for more input/filter/output configs.

Phew! At least something made the cut!

Need to thinker a bit on how to merge this .. :)

:-) no idea where to start there, I probably need to go back and submit smaller changes, but I'm not sure that's possible, it's all or nothing.

[haf]

So what's up with this PR? =)

[KrisBuytaert]

@haf as stated initially .. it was to big with too much changes that didn't match my vision..

I should have discussed this with @simonmcc whilst in London in March .. but ....

[simonmcc]

And I've got lazy at maintaing my fork, as I'm currently working in Chef shop..there are a bunch of PRs against my fork that I need to take care of.

On 20 May 2013 19:09, Kris Buytaert [email protected] wrote:

@haf https://github.com/haf as stated initially .. it was to big with too much changes that didn't match my vision..

I should have discussed this with @simonmcc https://github.com/simonmccwhilst in London in March .. but ....

— Reply to this email directly or view it on GitHubhttps://github.com/KrisBuytaert/puppet-logstash/pull/4#issuecomment-18162867 .

Simon McCartney E: [email protected] M: +44 7710 836 915