TSMessages
TSMessages copied to clipboard
Wrong Bundle (Cocoa Pods+Swift)
When using the new Coca Pods version (0.36) with Swift, there's a problem when using the framework. The Bundle is "main Bundle" when it should be bundleForClass.
This is easily solved by changing the lines in TSMessageView.m containing: [NSBundle mainBundle] // Lines 66, 81 With: [NSBundle bundleForClass:self.class]
The error is
*** Assertion failure in +[TSMessageView notificationDesign], /Users/.../TSMessages/Pod/Classes/TSMessageView.m:68
+1.
Hand in a Pull request :)
I might be missing something here, but pointing the pod to github, I don't have this issue. If I set the cocoapods version it does have this problem.
Looks like this was fixed in 38d3d83c62f176b7b72e9f3aa24a3aaa729a7857 which is after the latest release 0.9.12.
@KrauseFx It'd be awesome if you could release a new version with this fix so that it can be installed via cocoapods :grin: Thanks!
Yeah, @KrauseFx can we get a version bump on this one? ;)
@kiliankoe @davidrothera To be honest I'm afraid a new version introduces new errors, as the last release has been ages ago... I haven't had time to maintain TSMessages recently unfortunately. I'd like to bring TSMessages up to date again soon.
Is there a reason you don't want to define the :head
option in your Podfile
?
Yeah, I've gone that route for now, its only for a development branch at the moment so no real danger using :head and not a tagged version :+1:
+1 on a CocoaPods release for this.
+1 on a CocoaPods release for this, Head version uses an old version of HexColors (2.2.0). Thank you in advance.
:+1: on a CocoaPods release for this too !
+1 on a Cocoapods