TSMessages icon indicating copy to clipboard operation
TSMessages copied to clipboard

Wrong Bundle (Cocoa Pods+Swift)

Open SentoCrespo opened this issue 9 years ago • 12 comments

When using the new Coca Pods version (0.36) with Swift, there's a problem when using the framework. The Bundle is "main Bundle" when it should be bundleForClass.

This is easily solved by changing the lines in TSMessageView.m containing: [NSBundle mainBundle] // Lines 66, 81 With: [NSBundle bundleForClass:self.class]

SentoCrespo avatar Mar 16 '15 09:03 SentoCrespo

The error is

*** Assertion failure in +[TSMessageView notificationDesign], /Users/.../TSMessages/Pod/Classes/TSMessageView.m:68

jondot avatar Mar 19 '15 11:03 jondot

+1.

nunogoncalves avatar Apr 16 '15 13:04 nunogoncalves

Hand in a Pull request :)

mRs- avatar Apr 17 '15 08:04 mRs-

I might be missing something here, but pointing the pod to github, I don't have this issue. If I set the cocoapods version it does have this problem.

nunogoncalves avatar Apr 17 '15 08:04 nunogoncalves

Looks like this was fixed in 38d3d83c62f176b7b72e9f3aa24a3aaa729a7857 which is after the latest release 0.9.12.

@KrauseFx It'd be awesome if you could release a new version with this fix so that it can be installed via cocoapods :grin: Thanks!

kiliankoe avatar Apr 28 '15 22:04 kiliankoe

Yeah, @KrauseFx can we get a version bump on this one? ;)

davidrothera avatar May 13 '15 21:05 davidrothera

@kiliankoe @davidrothera To be honest I'm afraid a new version introduces new errors, as the last release has been ages ago... I haven't had time to maintain TSMessages recently unfortunately. I'd like to bring TSMessages up to date again soon.

Is there a reason you don't want to define the :head option in your Podfile?

KrauseFx avatar May 13 '15 21:05 KrauseFx

Yeah, I've gone that route for now, its only for a development branch at the moment so no real danger using :head and not a tagged version :+1:

davidrothera avatar May 13 '15 21:05 davidrothera

+1 on a CocoaPods release for this.

adamsp avatar Sep 14 '15 19:09 adamsp

+1 on a CocoaPods release for this, Head version uses an old version of HexColors (2.2.0). Thank you in advance.

fjsosa avatar Sep 24 '15 18:09 fjsosa

:+1: on a CocoaPods release for this too !

BenjaminDigeon avatar Sep 28 '15 14:09 BenjaminDigeon

+1 on a Cocoapods

IceFloe avatar Feb 14 '16 21:02 IceFloe