TSMessages icon indicating copy to clipboard operation
TSMessages copied to clipboard

Remove dependence on the HexColors pod.

Open onato opened this issue 11 years ago • 7 comments

I have removed this pod since it can be replaced by just a few lines of code.

Does anyone have objections?

onato avatar May 31 '14 16:05 onato

I guess that would be something for @mRs-, who is the developer of HexColors

KrauseFx avatar Jun 01 '14 19:06 KrauseFx

Why should we remove the pod? The Pod itself is just working fine. In all of my projects that are working with HexColors i would have doubled my code base…

mRs- avatar Jun 02 '14 06:06 mRs-

I agree with @mRs- here. It's an advantage to have a dependency to not pull the same code multiple times if it's already in the project

KrauseFx avatar Jun 02 '14 07:06 KrauseFx

We should remove it because it is not required to achieve the goal of the project. The user of our library could be using a number of other libraries that do the same thing (quick count on cocoapods 7). At present we force them to also include HexColors.

You raise a good point though Marcus. We can simplify further by not using hex codes to define our colours and removing the category I added.

If the user want to use hex codes they should decide which library they want to use.

onato avatar Jun 02 '14 07:06 onato

What alternative to Hex codes would you use in our JSON configuration?

KrauseFx avatar Jun 02 '14 07:06 KrauseFx

Sorry, an oversight, we need hex codes after all. However we should not tightly couple the project to another.

onato avatar Jun 02 '14 07:06 onato

:+1: because HexColors is now on version v2.3.0 and is outdated.

cameronehrlich avatar Oct 14 '15 10:10 cameronehrlich