Kratos icon indicating copy to clipboard operation
Kratos copied to clipboard

[GeoMechanicsApplication] Merge current GeoMechanicsBranch into master

Open carloslubbers opened this issue 2 years ago • 5 comments

📝 Description We wish to merge the work on the GeoMechanicsApplication from the past year back into the master branch.

🆕 Changelog Added groundwater flow and piping elements and processes to the GeoMechanicsApplication

carloslubbers avatar Jun 14 '22 11:06 carloslubbers

@carloslubbers I would highly suggest you to reduce the size of this PR.

pooyan-dadvand avatar Jul 07 '22 12:07 pooyan-dadvand

Hi @pooyan-dadvand we are actively working on reducing the size of the pull request currently, therefore it is still a draft! We've already halved in size and still have more cleaning up to do. The developments at Deltares for the GeoMechanicsApplication have been in this branch without a merge back for a year or two, but we're trying to rectify this and develop smaller chunks going forward

carloslubbers avatar Jul 07 '22 14:07 carloslubbers

Thank you! This would improve considerably the review process of the code!

pooyan-dadvand avatar Jul 08 '22 09:07 pooyan-dadvand

Hi all,

I think this is the cleanest we will get this PR, containing our tests and the implementation of backwards erosion piping that we want. Please advise if you see any other ways to split the PR into smaller chunks.

Moving forward we will be working on a 1 component 1 branch methodology with much smaller PR requests.

Regards

Jon

mcgicjn2 avatar Sep 14 '22 10:09 mcgicjn2

Thanks! We will still look at your comment regarding the executables folder this week, we may be removing them completely for the time being as we have figured out the way to work without them.

carloslubbers avatar Sep 21 '22 09:09 carloslubbers