Kratos
Kratos copied to clipboard
[GeoMechanicsApplication] Merge current GeoMechanicsBranch into master
📝 Description We wish to merge the work on the GeoMechanicsApplication from the past year back into the master branch.
🆕 Changelog Added groundwater flow and piping elements and processes to the GeoMechanicsApplication
@carloslubbers I would highly suggest you to reduce the size of this PR.
Hi @pooyan-dadvand we are actively working on reducing the size of the pull request currently, therefore it is still a draft! We've already halved in size and still have more cleaning up to do. The developments at Deltares for the GeoMechanicsApplication have been in this branch without a merge back for a year or two, but we're trying to rectify this and develop smaller chunks going forward
Thank you! This would improve considerably the review process of the code!
Hi all,
I think this is the cleanest we will get this PR, containing our tests and the implementation of backwards erosion piping that we want. Please advise if you see any other ways to split the PR into smaller chunks.
Moving forward we will be working on a 1 component 1 branch methodology with much smaller PR requests.
Regards
Jon
Thanks! We will still look at your comment regarding the executables folder this week, we may be removing them completely for the time being as we have figured out the way to work without them.