Kratos icon indicating copy to clipboard operation
Kratos copied to clipboard

[CLApp] Adding function accessor to the core (Thermomechanical PR related)

Open AlejandroCornejo opened this issue 2 years ago • 10 comments

📝 Description

In this PR I am adding a proposal to a property accessor prototype discussed in https://github.com/KratosMultiphysics/Kratos/pull/9053.

This is a work in progress, currently is defined only for doubles but it will be templated for any kind of variable. @RiccardoRossi @philbucher @loumalouomega @rubenzorrilla

Let the hunger games begin!

AlejandroCornejo avatar Jun 03 '22 10:06 AlejandroCornejo

Hi @loumalouomega ! it's true that it looks "empty" but this is the idea. This class is totally auxiliar. The properties will define new accessors according to your needs. In my case I need the standard return of the prop, and according to a table.

If another person needs an analytical evolution of the prop, he/she will add the accessor to the property.

I think this was the original idea of @RiccardoRossi :)

AlejandroCornejo avatar Jun 03 '22 10:06 AlejandroCornejo

I dont completely get the idea of how this works, At which moment and who adds the accessors? Are these ownned by the element..?

ddiezrod avatar Jun 03 '22 11:06 ddiezrod

I dont completely get the idea of how this works, At which moment and who adds the accessors? Are these ownned by the element..?

A test would clarify...

loumalouomega avatar Jun 03 '22 11:06 loumalouomega

I dont completely get the idea of how this works, At which moment and who adds the accessors? Are these ownned by the element..?

Hi! the discussion is here: https://github.com/KratosMultiphysics/Kratos/pull/9053

The accessor will be inside the Properties :)

AlejandroCornejo avatar Jun 03 '22 13:06 AlejandroCornejo

I dont completely get the idea of how this works, At which moment and who adds the accessors? Are these ownned by the element..?

A test would clarify...

I'll do a test when a proper implementation is decided 👯

AlejandroCornejo avatar Jun 03 '22 13:06 AlejandroCornejo

I dont completely get the idea of how this works, At which moment and who adds the accessors? Are these ownned by the element..?

Hi! the discussion is here: #9053

The accessor will be inside the Properties :)

So when you add a new property (e.g. DENSITY) to the properties container, you also add an accessor to it? I think that would work, although you will not be able to have two properties with same name with different types (probably its better that this is not allowed but it could break code I guess)

ddiezrod avatar Jun 03 '22 14:06 ddiezrod

@jrubiogonzalez this could be of your interest

loumalouomega avatar Aug 08 '22 12:08 loumalouomega

@jrubiogonzalez this could be of your interest

Actually I'd like to really move this forward... For a project we want this to be available in the master. I offer myself to implement this but I need your opinion and support!! :) @RiccardoRossi @loumalouomega

AlejandroCornejo avatar Aug 08 '22 12:08 AlejandroCornejo

@jrubiogonzalez this could be of your interest

Actually I'd like to really move this forward... For a project we want this to be available in the master. I offer myself to implement this but I need your opinion and support!! :) @RiccardoRossi @loumalouomega

I was pinging because I think in @KratosMultiphysics/altair this feature will be valuable. Maybe we can discuss soon all together soon.

loumalouomega avatar Aug 08 '22 12:08 loumalouomega

@jrubiogonzalez this could be of your interest

Actually I'd like to really move this forward... For a project we want this to be available in the master. I offer myself to implement this but I need your opinion and support!! :) @RiccardoRossi @loumalouomega

I was pinging because I think in @KratosMultiphysics/altair this feature will be valuable. Maybe we can discuss soon all together soon.

That could be great!! let me know whenever you start with this

AlejandroCornejo avatar Aug 08 '22 12:08 AlejandroCornejo