Kratos icon indicating copy to clipboard operation
Kratos copied to clipboard

[Core] Adding kernel library list

Open loumalouomega opened this issue 4 years ago • 6 comments

📝 Description In order to skip tests depending on library disponibility

🆕 Changelog

  • Adding kernel library list
  • Expose to python
  • Added test
  • Reactivate CadModeler if triangle is available

loumalouomega avatar Nov 10 '21 11:11 loumalouomega

@KratosMultiphysics/technical-committee we believe that the idea is very good and useful. Nevertheless, we see that having them all in the kernel is not the best way to maintain them.

We think that a better mechanism would be to use the new Registry under "third_party_libraries" and add each of them in their relative wrappers. (for example, json in our Parameters class)

pooyan-dadvand avatar Nov 15 '21 09:11 pooyan-dadvand

@KratosMultiphysics/technical-committee we believe that the idea is very good and useful. Nevertheless, we see that having them all in the kernel is not the best way to maintain them.

I did it in order to be consistent with the applications

We think that a better mechanism would be to use the new Registry under "third_party_libraries" and add each of them in their relative wrappers. (for example, json in our Parameters class)

1- Is the Registry already merged? 2- I think not all libraries have a wrapper, F.E triangle is called in many places. The current structure using Registry should work fine

loumalouomega avatar Nov 15 '21 09:11 loumalouomega

What is the status of this¿? https://github.com/orgs/KratosMultiphysics/teams/technical-committee

loumalouomega avatar Jul 26 '22 11:07 loumalouomega

What is the status of this¿? github.com/orgs/KratosMultiphysics/teams/technical-committee

👋

loumalouomega avatar Sep 19 '22 09:09 loumalouomega