[Core] Adding Newton-Cotes integration points for line

[loumalouomega]

Part of the fix for #6646.

[loumalouomega]

@pooyan-dadvand I'm having problem sdefining the integrations points as a static member variable of the line (non const), with the corresponding method in order to modify the extended methods so this integration points can be considered. For now I only add the integration points definition

[loumalouomega]

@Vahid-Galavi in the added test you can see how to use it

[loumalouomega]

Because it was generated with a matlab script from the Felippa webpage...

On Thu, 30 Apr 2020 at 12:55, Guillermo Casas [email protected] wrote:

@GuillermoCasas commented on this pull request.

In kratos/integration/line_newton_cotes_integration_points.h https://github.com/KratosMultiphysics/Kratos/pull/6734#discussion_r417925603 :

• typedef IntegrationPoint<1> IntegrationPointType;
• typedef std::array<IntegrationPointType, 3> IntegrationPointsArrayType;
• typedef IntegrationPointType::PointType PointType;
• static SizeType IntegrationPointsNumber()
• {

•    return 3;
  

• }
• static IntegrationPointsArrayType& IntegrationPoints()
• {

•    // This is added to solve the problem of static initialization. Pooyan.
  

•    msIntegrationPoints[0]=IntegrationPointType(-0.5,1.333333333333333);
  

why not use actual fractions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KratosMultiphysics/Kratos/pull/6734#pullrequestreview-403411765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYQZAES2X7YFBA6CSTON5DRPFKK3ANCNFSM4MDKUJ6Q .

[GuillermoCasas]

On behalf of the @KratosMultiphysics/implementation-committee , this PR is ready to merge. The PR adds a new integration rule together with the appropriate test, which also serves as a test for the changes in #6745. We leave it to the @KratosMultiphysics/technical-committee to give their final decision on the topic.

[loumalouomega]

This is ready after merging #6926 @pooyan-dadvand

[loumalouomega]

I clean up what you mentioned @pooyan-dadvand. On the other hand, the integration method was added after the request of @Vahid-Galavi

[pooyan-dadvand]

I completely agree with adding the integration method.

Here, the discussion is about the interfaces and the details of the implementation.

Same comment is also applied to the rest of the "Specialized" methods for external integration points. So let check the other opinions.

Also, @KratosMultiphysics/technical-committee?

[loumalouomega]

@philbucher CI is not working due to mmg...

[RiccardoRossi]

same as #6745

[loumalouomega]

I think this can be retaken @KratosMultiphysics/technical-committee

[loumalouomega]

What is the status of this¿? https://github.com/orgs/KratosMultiphysics/teams/technical-committee

[loumalouomega]

What is the status of this¿? github.com/orgs/KratosMultiphysics/teams/technical-committee

👋