[Core] Consistency between Element/Condition and Node clone

[loumalouomega]

The clone of the node does not consider new Id:

https://github.com/KratosMultiphysics/Kratos/blob/fbb7be7bcf6c1b6c5c5cd2233488cf382816adcd/kratos/includes/node.h#L328

But the condition and element does:

https://github.com/KratosMultiphysics/Kratos/blob/231a4d1451377b593791cc330ec1a052a1594ea0/kratos/includes/element.h#L233

Maybe we should discuss this inconsistency

[loumalouomega]

I think this discussion is still valid

[loumalouomega]

I think this discussion is still valid

@KratosMultiphysics/technical-committee

[roigcarlo]

@loumalouomega We are currently considering options to "merge" elements and conditions. As long as the PR is ready we will ping everyone.

In the meantime, I agree with you, its odd that they have different interfaces :S

[loumalouomega]

@loumalouomega We are currently considering options to "merge" elements and conditions. As long as the PR is ready we will ping everyone.

In the meantime, I agree with you, its odd that they have different interfaces :S

It is nice to unify elements and conditions, as implementation is 99.9% identical. In any case, this discussion is still valid.

[pooyan-dadvand]

@KratosMultiphysics/technical-committee don't see any reason for having the Clone method for the node as we don't derive from it. So we propose to remove the Clone of the node (and implicitly we don't have inconsistency anymore)